Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Type, Helper] Remove unused __STL_MEMBER_TEMPLATES parts #4251

Merged
merged 5 commits into from
Nov 3, 2023
Merged

[Type, Helper] Remove unused __STL_MEMBER_TEMPLATES parts #4251

merged 5 commits into from
Nov 3, 2023

Conversation

fredroy
Copy link
Contributor

@fredroy fredroy commented Oct 23, 2023

It seems to come from some very old version of the STL from SGI (google is not very prolix on this)
In any case, this is not defined by the STL of msvc, libc++ (llvm) and libstdc++ (gnu gcc)

By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).

Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@fredroy fredroy added pr: status to review To notify reviewers to review this pull-request pr: clean Cleaning the code labels Oct 23, 2023
alxbilger
alxbilger reviewed Oct 23, 2023
View reviewed changes
Copy link
Contributor

@alxbilger alxbilger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree to remove the macro, but why removing the template? I think it matches better the constructors available in the STL.

@fredroy
Copy link
Contributor Author

fredroy commented Oct 23, 2023

I agree to remove the macro, but why removing the template? I think it matches better the constructors available in the STL.

I was wondering the same, but everything was tested with __STL_MEMBER_TEMPLATES not defined for years so thats why I prefered to use the "legacy" code. But I can change and take the templated one otherwise 😶‍🌫️

@alxbilger
Copy link
Contributor

[ci-build][with-all-tests]

@alxbilger
Copy link
Contributor

I agree to remove the macro, but why removing the template? I think it matches better the constructors available in the STL.

I was wondering the same, but everything was tested with __STL_MEMBER_TEMPLATES not defined for years so thats why I prefered to use the "legacy" code. But I can change and take the templated one otherwise 😶‍🌫️

alright, I am not against it. It's not that important

@hugtalbot hugtalbot added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Oct 25, 2023
@epernod epernod merged commit 14bfbd3 into sofa-framework:master Nov 3, 2023
2 checks passed
@hugtalbot hugtalbot added this to the v23.12 milestone Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alxbilger alxbilger alxbilger left review comments

@bakpaul bakpaul bakpaul approved these changes

@hugtalbot hugtalbot hugtalbot approved these changes

Assignees
No one assigned
Labels
pr: clean Cleaning the code pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Milestone
v23.12
Development

Successfully merging this pull request may close these issues.
5 participants
@fredroy @alxbilger @hugtalbot @bakpaul @epernod